Release v0.0.0.8

Starface API:
- Handle both array and object responses from /contacts endpoint
- Try common wrapper fields (items, contacts, data, results)

Outlook contacts:
- Add FindFolderByPath that matches exact FolderPath property
- Fallback to Namespace.Folders navigation if store lookup fails
- Fallback: try reading contact fields even if Class != 40
- Add debug logging for folder path and item count

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

installer/setup.iss

@@ -2,7 +2,7 @@
 ; Erfordert Inno Setup 6.x (https://jrsoftware.org/isinfo.php)
 
 #define MyAppName "Starface Outlook Sync"
-#define MyAppVersion "0.0.0.5"
+#define MyAppVersion "0.0.0.8"
 #define MyAppPublisher "HackerSoft - Hacker-Net Telekommunikation"
 #define MyAppURL "https://www.hacker-net.de"
 #define MyAppExeName "StarfaceOutlookSync.exe"

src/StarfaceOutlookSync/Services/OutlookContactsService.cs

@@ -2,44 +2,75 @@ using System;
 using System.Collections.Generic;
 using System.Runtime.InteropServices;
 using StarfaceOutlookSync.Models;
-using Outlook = Microsoft.Office.Interop.Outlook;
 
 namespace StarfaceOutlookSync.Services
 {
+    /// <summary>
+    /// Zugriff auf Outlook-Kontakte per dynamic COM.
+    /// Funktioniert mit jeder Outlook Classic Version (2013-2024)
+    /// ohne Abhaengigkeit von einer bestimmten Interop-DLL.
+    /// </summary>
     public class OutlookContactsService : IDisposable
     {
-        private Outlook.Application _outlookApp;
+        private dynamic _outlookApp;
         private bool _weStartedOutlook;
 
-        // Marshal.GetActiveObject existiert nicht in .NET 8, daher P/Invoke
+        // OlDefaultFolders.olFolderContacts = 10
+        private const int OlFolderContacts = 10;
+        // OlItemType.olContactItem = 2
+        private const int OlContactItem = 2;
+
         [DllImport("oleaut32.dll", PreserveSig = false)]
-        private static extern void GetActiveObject([MarshalAs(UnmanagedType.LPStruct)] Guid rclsid, IntPtr pvReserved, [MarshalAs(UnmanagedType.IUnknown)] out object ppunk);
+        private static extern void GetActiveObject(
+            [MarshalAs(UnmanagedType.LPStruct)] Guid rclsid,
+            IntPtr pvReserved,
+            [MarshalAs(UnmanagedType.IUnknown)] out object ppunk);
 
         private static object GetActiveComObject(string progId)
         {
-            var clsid = Type.GetTypeFromProgID(progId, true).GUID;
-            GetActiveObject(clsid, IntPtr.Zero, out var obj);
+            var type = Type.GetTypeFromProgID(progId, false);
+            if (type == null) return null;
+            GetActiveObject(type.GUID, IntPtr.Zero, out var obj);
             return obj;
         }
 
-        private Outlook.Application GetOutlookApp()
+        private dynamic GetOutlookApp()
         {
             if (_outlookApp != null) return _outlookApp;
 
+            // Versuch 1: Laufende Outlook-Instanz finden
             try
             {
-                // Versuche laufende Outlook-Instanz zu finden
-                _outlookApp = (Outlook.Application)GetActiveComObject("Outlook.Application");
-                _weStartedOutlook = false;
-            }
-            catch
-            {
-                // Outlook starten falls nicht laufend
-                _outlookApp = new Outlook.Application();
-                _weStartedOutlook = true;
+                var obj = GetActiveComObject("Outlook.Application");
+                if (obj != null)
+                {
+                    _outlookApp = obj;
+                    _weStartedOutlook = false;
+                    return _outlookApp;
+                }
             }
+            catch { }
 
-            return _outlookApp;
+            // Versuch 2: Outlook per COM starten
+            try
+            {
+                var outlookType = Type.GetTypeFromProgID("Outlook.Application", false);
+                if (outlookType != null)
+                {
+                    _outlookApp = Activator.CreateInstance(outlookType);
+                    _weStartedOutlook = true;
+                    return _outlookApp;
+                }
+            }
+            catch { }
+
+            throw new InvalidOperationException(
+                "Outlook Classic konnte nicht gefunden werden.\n\n" +
+                "Moegliche Ursachen:\n" +
+                "- Outlook Classic ist nicht installiert\n" +
+                "- Outlook Classic ist nicht gestartet\n" +
+                "- Das neue Outlook wird verwendet (wird noch nicht unterstuetzt)\n\n" +
+                "Bitte Outlook Classic starten und erneut versuchen.");
         }
 
         public List<string> GetContactFolderPaths()
@@ -50,18 +81,21 @@ namespace StarfaceOutlookSync.Services
                 var app = GetOutlookApp();
                 var ns = app.GetNamespace("MAPI");
 
-                // Alle Stores durchgehen (jedes Konto, jede PST-Datei etc.)
-                foreach (Outlook.Store store in ns.Stores)
+                // Alle Stores durchgehen
+                var stores = ns.Stores;
+                for (int i = 1; i <= (int)stores.Count; i++)
                 {
                     try
                     {
+                        var store = stores[i];
                         var rootFolder = store.GetRootFolder();
                         FindContactFoldersRecursive(rootFolder, folders);
                         Marshal.ReleaseComObject(rootFolder);
+                        Marshal.ReleaseComObject(store);
                     }
                     catch (Exception ex)
                     {
-                        System.Diagnostics.Debug.WriteLine($"Error scanning store '{store.DisplayName}': {ex.Message}");
+                        System.Diagnostics.Debug.WriteLine($"Error scanning store {i}: {ex.Message}");
                     }
                 }
 
@@ -70,121 +104,212 @@ namespace StarfaceOutlookSync.Services
                 {
                     try
                     {
-                        var defaultFolder = ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts);
-                        folders.Add(defaultFolder.FolderPath);
+                        var defaultFolder = ns.GetDefaultFolder(OlFolderContacts);
+                        folders.Add((string)defaultFolder.FolderPath);
                         Marshal.ReleaseComObject(defaultFolder);
                     }
                     catch { }
                 }
 
+                Marshal.ReleaseComObject(stores);
                 Marshal.ReleaseComObject(ns);
             }
             catch (Exception ex)
             {
                 System.Diagnostics.Debug.WriteLine($"Error getting folders: {ex.Message}");
+                throw;
             }
 
             return folders;
         }
 
-        private void FindContactFoldersRecursive(Outlook.MAPIFolder folder, List<string> paths)
+        private void FindContactFoldersRecursive(dynamic folder, List<string> paths)
         {
             try
             {
-                // Kontaktordner erkennen: DefaultItemType ODER Ordnername enthaelt "Kontakt"/"Contact"
-                if (folder.DefaultItemType == Outlook.OlItemType.olContactItem)
+                if ((int)folder.DefaultItemType == OlContactItem)
                 {
-                    if (!paths.Contains(folder.FolderPath))
-                        paths.Add(folder.FolderPath);
+                    string path = folder.FolderPath;
+                    if (!paths.Contains(path))
+                        paths.Add(path);
                 }
 
-                // Alle Unterordner durchsuchen
-                foreach (Outlook.MAPIFolder sub in folder.Folders)
+                var subFolders = folder.Folders;
+                for (int i = 1; i <= (int)subFolders.Count; i++)
                 {
                     try
                     {
+                        var sub = subFolders[i];
                         FindContactFoldersRecursive(sub, paths);
-                    }
-                    catch { }
-                    finally
-                    {
                         Marshal.ReleaseComObject(sub);
                     }
+                    catch { }
                 }
+                Marshal.ReleaseComObject(subFolders);
             }
             catch (Exception ex)
             {
-                System.Diagnostics.Debug.WriteLine($"Error scanning folder '{folder.Name}': {ex.Message}");
+                System.Diagnostics.Debug.WriteLine($"Error scanning folder: {ex.Message}");
             }
         }
 
-        private Outlook.MAPIFolder GetFolderByPath(string folderPath)
+        private dynamic FindFolderByPath(dynamic folder, string targetPath)
+        {
+            try
+            {
+                string currentPath = folder.FolderPath;
+                if (currentPath == targetPath)
+                    return folder;
+
+                var subs = folder.Folders;
+                for (int i = 1; i <= (int)subs.Count; i++)
+                {
+                    try
+                    {
+                        var sub = subs[i];
+                        var match = FindFolderByPath(sub, targetPath);
+                        if (match != null) return match;
+                        Marshal.ReleaseComObject(sub);
+                    }
+                    catch { }
+                }
+                Marshal.ReleaseComObject(subs);
+            }
+            catch { }
+            return null;
+        }
+
+        private dynamic GetFolderByPath(string folderPath)
         {
             var app = GetOutlookApp();
             var ns = app.GetNamespace("MAPI");
 
-            // Standard-Kontaktordner als Fallback
             if (string.IsNullOrEmpty(folderPath))
-                return ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts);
+                return ns.GetDefaultFolder(OlFolderContacts);
 
             try
             {
-                // Pfad durchlaufen
-                var parts = folderPath.Split(new[] { '\\' }, StringSplitOptions.RemoveEmptyEntries);
-                Outlook.MAPIFolder current = null;
-
-                foreach (Outlook.Store store in ns.Stores)
+                // Versuch 1: Alle Kontaktordner durchsuchen und per FolderPath matchen
+                var stores = ns.Stores;
+                for (int i = 1; i <= (int)stores.Count; i++)
                 {
-                    if (store.GetRootFolder().Name == parts[0] ||
-                        store.GetRootFolder().FolderPath.TrimStart('\\') == parts[0])
+                    try
                     {
-                        current = store.GetRootFolder();
-                        break;
-                    }
-                }
-
-                if (current == null)
-                    return ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts);
-
-                for (int i = 1; i < parts.Length; i++)
-                {
-                    bool found = false;
-                    foreach (Outlook.MAPIFolder sub in current.Folders)
-                    {
-                        if (sub.Name == parts[i])
+                        var store = stores[i];
+                        var root = store.GetRootFolder();
+                        var match = FindFolderByPath(root, folderPath);
+                        if (match != null)
                         {
-                            current = sub;
-                            found = true;
-                            break;
+                            Marshal.ReleaseComObject(stores);
+                            return match;
                         }
+                        Marshal.ReleaseComObject(root);
+                        Marshal.ReleaseComObject(store);
                     }
-                    if (!found)
-                        return ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts);
+                    catch { }
+                }
+                Marshal.ReleaseComObject(stores);
+
+                // Versuch 2: Namespace.Folders direkt navigieren
+                var parts = folderPath.Split(new[] { '\\' }, StringSplitOptions.RemoveEmptyEntries);
+                if (parts.Length >= 1)
+                {
+                    var topFolders = ns.Folders;
+                    for (int i = 1; i <= (int)topFolders.Count; i++)
+                    {
+                        var topFolder = topFolders[i];
+                        if ((string)topFolder.Name == parts[0])
+                        {
+                            dynamic current = topFolder;
+                            for (int p = 1; p < parts.Length; p++)
+                            {
+                                bool found = false;
+                                var subs = current.Folders;
+                                for (int j = 1; j <= (int)subs.Count; j++)
+                                {
+                                    var sub = subs[j];
+                                    if ((string)sub.Name == parts[p])
+                                    {
+                                        current = sub;
+                                        found = true;
+                                        break;
+                                    }
+                                    Marshal.ReleaseComObject(sub);
+                                }
+                                Marshal.ReleaseComObject(subs);
+                                if (!found) { current = null; break; }
+                            }
+                            if (current != null)
+                            {
+                                Marshal.ReleaseComObject(topFolders);
+                                return current;
+                            }
+                        }
+                        Marshal.ReleaseComObject(topFolder);
+                    }
+                    Marshal.ReleaseComObject(topFolders);
                 }
 
-                return current;
+                System.Diagnostics.Debug.WriteLine($"Folder not found by path: {folderPath}, using default");
+                return ns.GetDefaultFolder(OlFolderContacts);
             }
             catch
             {
-                return ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts);
+                return ns.GetDefaultFolder(OlFolderContacts);
             }
         }
 
         public List<UnifiedContact> GetContacts(string folderPath)
         {
             var contacts = new List<UnifiedContact>();
-
             try
             {
                 var folder = GetFolderByPath(folderPath);
-                var items = folder.Items;
+                System.Diagnostics.Debug.WriteLine($"Reading contacts from: {(string)folder.FolderPath}");
 
-                foreach (var item in items)
+                var items = folder.Items;
+                int count = (int)items.Count;
+                System.Diagnostics.Debug.WriteLine($"Items count: {count}");
+
+                for (int i = 1; i <= count; i++)
                 {
-                    if (item is Outlook.ContactItem ci)
+                    dynamic item = null;
+                    try
                     {
-                        contacts.Add(MapFromOutlook(ci));
-                        Marshal.ReleaseComObject(ci);
+                        item = items[i];
+                        int itemClass = -1;
+                        try { itemClass = (int)item.Class; } catch { }
+
+                        // olContact = 40, aber manche Kontakte melden Class anders
+                        // Versuch einfach die Kontakt-Felder zu lesen
+                        if (itemClass == 40)
+                        {
+                            contacts.Add(MapFromOutlook(item));
+                        }
+                        else
+                        {
+                            // Fallback: Pruefen ob es trotzdem ein Kontakt ist
+                            try
+                            {
+                                string eid = item.EntryID;
+                                string fn = item.FirstName;
+                                string ln = item.LastName;
+                                // Hat Kontakt-Felder -> ist ein Kontakt
+                                contacts.Add(MapFromOutlook(item));
+                            }
+                            catch
+                            {
+                                // Kein Kontakt, ueberspringen
+                            }
+                        }
+                    }
+                    catch (Exception ex)
+                    {
+                        System.Diagnostics.Debug.WriteLine($"Error reading item {i}: {ex.Message}");
+                    }
+                    finally
+                    {
+                        if (item != null) try { Marshal.ReleaseComObject(item); } catch { }
                     }
                 }
 
@@ -204,7 +329,8 @@ namespace StarfaceOutlookSync.Services
             try
             {
                 var folder = GetFolderByPath(folderPath);
-                var ci = (Outlook.ContactItem)folder.Items.Add(Outlook.OlItemType.olContactItem);
+                var items = folder.Items;
+                dynamic ci = items.Add(OlContactItem);
 
                 MapToOutlook(contact, ci);
                 ci.Save();
@@ -212,6 +338,7 @@ namespace StarfaceOutlookSync.Services
                 contact.OutlookEntryId = ci.EntryID;
 
                 Marshal.ReleaseComObject(ci);
+                Marshal.ReleaseComObject(items);
                 Marshal.ReleaseComObject(folder);
 
                 return contact;
@@ -229,7 +356,7 @@ namespace StarfaceOutlookSync.Services
             {
                 var app = GetOutlookApp();
                 var ns = app.GetNamespace("MAPI");
-                var ci = (Outlook.ContactItem)ns.GetItemFromID(entryId);
+                dynamic ci = ns.GetItemFromID(entryId);
 
                 MapToOutlook(contact, ci);
                 ci.Save();
@@ -252,7 +379,7 @@ namespace StarfaceOutlookSync.Services
             {
                 var app = GetOutlookApp();
                 var ns = app.GetNamespace("MAPI");
-                var ci = (Outlook.ContactItem)ns.GetItemFromID(entryId);
+                dynamic ci = ns.GetItemFromID(entryId);
 
                 ci.Delete();
                 Marshal.ReleaseComObject(ci);
@@ -267,36 +394,46 @@ namespace StarfaceOutlookSync.Services
             }
         }
 
-        private UnifiedContact MapFromOutlook(Outlook.ContactItem ci)
+        private UnifiedContact MapFromOutlook(dynamic ci)
         {
             return new UnifiedContact
             {
-                OutlookEntryId = ci.EntryID ?? "",
-                FirstName = ci.FirstName ?? "",
-                LastName = ci.LastName ?? "",
-                Company = ci.CompanyName ?? "",
-                JobTitle = ci.JobTitle ?? "",
-                Email = ci.Email1Address ?? "",
-                EmailSecondary = ci.Email2Address ?? "",
-                PhoneWork = ci.BusinessTelephoneNumber ?? "",
-                PhoneMobile = ci.MobileTelephoneNumber ?? "",
-                PhoneHome = ci.HomeTelephoneNumber ?? "",
-                Fax = ci.BusinessFaxNumber ?? "",
-                Street = ci.BusinessAddressStreet ?? "",
-                City = ci.BusinessAddressCity ?? "",
-                PostalCode = ci.BusinessAddressPostalCode ?? "",
-                State = ci.BusinessAddressState ?? "",
-                Country = ci.BusinessAddressCountry ?? "",
-                Website = ci.WebPage ?? "",
-                Notes = ci.Body ?? "",
-                Salutation = ci.Title ?? "",
-                Title = ci.Suffix ?? "",
-                Birthday = ci.Birthday != DateTime.MinValue && ci.Birthday.Year > 1900
-                    ? ci.Birthday.ToString("yyyy-MM-dd") : ""
+                OutlookEntryId = (string)(ci.EntryID ?? ""),
+                FirstName = (string)(ci.FirstName ?? ""),
+                LastName = (string)(ci.LastName ?? ""),
+                Company = (string)(ci.CompanyName ?? ""),
+                JobTitle = (string)(ci.JobTitle ?? ""),
+                Email = (string)(ci.Email1Address ?? ""),
+                EmailSecondary = (string)(ci.Email2Address ?? ""),
+                PhoneWork = (string)(ci.BusinessTelephoneNumber ?? ""),
+                PhoneMobile = (string)(ci.MobileTelephoneNumber ?? ""),
+                PhoneHome = (string)(ci.HomeTelephoneNumber ?? ""),
+                Fax = (string)(ci.BusinessFaxNumber ?? ""),
+                Street = (string)(ci.BusinessAddressStreet ?? ""),
+                City = (string)(ci.BusinessAddressCity ?? ""),
+                PostalCode = (string)(ci.BusinessAddressPostalCode ?? ""),
+                State = (string)(ci.BusinessAddressState ?? ""),
+                Country = (string)(ci.BusinessAddressCountry ?? ""),
+                Website = (string)(ci.WebPage ?? ""),
+                Notes = (string)(ci.Body ?? ""),
+                Salutation = (string)(ci.Title ?? ""),
+                Birthday = GetBirthdayString(ci)
             };
         }
 
-        private void MapToOutlook(UnifiedContact contact, Outlook.ContactItem ci)
+        private string GetBirthdayString(dynamic ci)
+        {
+            try
+            {
+                DateTime bday = ci.Birthday;
+                if (bday.Year > 1900 && bday != DateTime.MinValue)
+                    return bday.ToString("yyyy-MM-dd");
+            }
+            catch { }
+            return "";
+        }
+
+        private void MapToOutlook(UnifiedContact contact, dynamic ci)
         {
             ci.FirstName = contact.FirstName;
             ci.LastName = contact.LastName;
@@ -333,7 +470,7 @@ namespace StarfaceOutlookSync.Services
                 {
                     try { _outlookApp.Quit(); } catch { }
                 }
-                Marshal.ReleaseComObject(_outlookApp);
+                try { Marshal.ReleaseComObject(_outlookApp); } catch { }
                 _outlookApp = null;
             }
         }

src/StarfaceOutlookSync/Services/StarfaceApiClient.cs

@@ -172,7 +172,38 @@ namespace StarfaceOutlookSync.Services
                 var resp = await _http.GetAsync($"{_baseUrl}/contacts?{query}");
                 if (!resp.IsSuccessStatusCode) break;
 
-                var array = JArray.Parse(await resp.Content.ReadAsStringAsync());
+                var body = await resp.Content.ReadAsStringAsync();
+                JArray array;
+
+                // Die API gibt je nach Version ein Array oder ein Objekt mit "items" zurueck
+                var token = JToken.Parse(body);
+                if (token is JArray directArray)
+                {
+                    array = directArray;
+                }
+                else if (token is JObject obj)
+                {
+                    // Versuche gaengige Felder: items, contacts, data, results
+                    array = (obj["items"] ?? obj["contacts"] ?? obj["data"] ?? obj["results"]) as JArray;
+                    if (array == null)
+                    {
+                        // Einzelnes Kontakt-Objekt? Dann in Array wrappen
+                        if (obj["id"] != null && obj["blocks"] != null)
+                        {
+                            array = new JArray { obj };
+                        }
+                        else
+                        {
+                            System.Diagnostics.Debug.WriteLine($"Unerwartete Starface-Antwort: {body.Substring(0, Math.Min(200, body.Length))}");
+                            break;
+                        }
+                    }
+                }
+                else
+                {
+                    break;
+                }
+
                 if (array.Count == 0) break;
 
                 foreach (var item in array)

src/StarfaceOutlookSync/StarfaceOutlookSync.csproj

@@ -7,9 +7,9 @@
     <AssemblyTitle>Starface Outlook Sync</AssemblyTitle>
     <Company>HackerSoft - Hacker-Net Telekommunikation</Company>
     <Product>Starface Outlook Sync</Product>
-    <Version>0.0.0.5</Version>
-    <AssemblyVersion>0.0.0.5</AssemblyVersion>
-    <FileVersion>0.0.0.5</FileVersion>
+    <Version>0.0.0.8</Version>
+    <AssemblyVersion>0.0.0.8</AssemblyVersion>
+    <FileVersion>0.0.0.8</FileVersion>
     <Description>Synchronisiert Outlook-Kontakte mit Starface Telefonanlage</Description>
     <Copyright>Stefan Hacker - HackerSoft</Copyright>
     <RuntimeIdentifier>win-x64</RuntimeIdentifier>
@@ -19,7 +19,6 @@
 
   <ItemGroup>
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
-    <PackageReference Include="Microsoft.Office.Interop.Outlook" Version="15.0.4797.1004" />
   </ItemGroup>
 
 </Project>

src/StarfaceOutlookSync/UI/AboutForm.cs

@@ -27,7 +27,7 @@ namespace StarfaceOutlookSync.UI
 
             var lblVersion = new Label
             {
-                Text = "Version 0.0.0.5",
+                Text = "Version 0.0.0.8",
                 Left = 0, Top = 56, Width = 340, Height = 20,
                 TextAlign = ContentAlignment.MiddleCenter,
                 ForeColor = Color.Gray