Hacker-Software
/
starface-outlook-sync-addin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 22 Wiki Activity

Replace Outlook Interop NuGet with dynamic COM binding 

The NuGet package Microsoft.Office.Interop.Outlook v15 tried to
load Office v15 PIA which fails on Office 2016/2019/2024 (v16).

Switch to dynamic COM (late binding) which works with ANY Outlook
Classic version without needing a specific Interop DLL. All Outlook
properties and methods are accessed via dynamic dispatch.

Also use 1-based COM collection indexing instead of foreach to
avoid COM enumerator issues.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
duffyduck 2026-04-03 12:01:49 +02:00
parent 499763d81f
commit 59d4c094a9
2 changed files with 127 additions and 77 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

203
src/StarfaceOutlookSync/Services/OutlookContactsService.cs
View File

@ -2,46 +2,62 @@ using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Runtime.InteropServices; using System.Runtime.InteropServices;
using StarfaceOutlookSync.Models; using StarfaceOutlookSync.Models;
using Outlook = Microsoft.Office.Interop.Outlook;
namespace StarfaceOutlookSync.Services namespace StarfaceOutlookSync.Services
{ {
/// <summary>
/// Zugriff auf Outlook-Kontakte per dynamic COM.
/// Funktioniert mit jeder Outlook Classic Version (2013-2024)
/// ohne Abhaengigkeit von einer bestimmten Interop-DLL.
/// </summary>
public class OutlookContactsService : IDisposable public class OutlookContactsService : IDisposable
{ {
private Outlook.Application _outlookApp; private dynamic _outlookApp;
private bool _weStartedOutlook; private bool _weStartedOutlook;
// Marshal.GetActiveObject existiert nicht in .NET 8, daher P/Invoke // OlDefaultFolders.olFolderContacts = 10
private const int OlFolderContacts = 10;
// OlItemType.olContactItem = 2
private const int OlContactItem = 2;
[DllImport("oleaut32.dll", PreserveSig = false)] [DllImport("oleaut32.dll", PreserveSig = false)]
private static extern void GetActiveObject([MarshalAs(UnmanagedType.LPStruct)] Guid rclsid, IntPtr pvReserved, [MarshalAs(UnmanagedType.IUnknown)] out object ppunk); private static extern void GetActiveObject(
[MarshalAs(UnmanagedType.LPStruct)] Guid rclsid,
IntPtr pvReserved,
[MarshalAs(UnmanagedType.IUnknown)] out object ppunk);
private static object GetActiveComObject(string progId) private static object GetActiveComObject(string progId)
{ {
var clsid = Type.GetTypeFromProgID(progId, true).GUID; var type = Type.GetTypeFromProgID(progId, false);
GetActiveObject(clsid, IntPtr.Zero, out var obj); if (type == null) return null;
GetActiveObject(type.GUID, IntPtr.Zero, out var obj);
return obj; return obj;
} }
private Outlook.Application GetOutlookApp() private dynamic GetOutlookApp()
{ {
if (_outlookApp != null) return _outlookApp; if (_outlookApp != null) return _outlookApp;
// Versuch 1: Laufende Outlook-Instanz finden // Versuch 1: Laufende Outlook-Instanz finden
try try
{ {
_outlookApp = (Outlook.Application)GetActiveComObject("Outlook.Application"); var obj = GetActiveComObject("Outlook.Application");
_weStartedOutlook = false; if (obj != null)
return _outlookApp; {
_outlookApp = obj;
_weStartedOutlook = false;
return _outlookApp;
}
} }
catch { } catch { }
// Versuch 2: Outlook per COM starten // Versuch 2: Outlook per COM starten
try try
{ {
var outlookType = Type.GetTypeFromProgID("Outlook.Application"); var outlookType = Type.GetTypeFromProgID("Outlook.Application", false);
if (outlookType != null) if (outlookType != null)
{ {
_outlookApp = (Outlook.Application)Activator.CreateInstance(outlookType); _outlookApp = Activator.CreateInstance(outlookType);
_weStartedOutlook = true; _weStartedOutlook = true;
return _outlookApp; return _outlookApp;
} }
@ -65,18 +81,21 @@ namespace StarfaceOutlookSync.Services
var app = GetOutlookApp(); var app = GetOutlookApp();
var ns = app.GetNamespace("MAPI"); var ns = app.GetNamespace("MAPI");
// Alle Stores durchgehen (jedes Konto, jede PST-Datei etc.) // Alle Stores durchgehen
foreach (Outlook.Store store in ns.Stores) var stores = ns.Stores;
for (int i = 1; i <= (int)stores.Count; i++)
{ {
try try
{ {
var store = stores[i];
var rootFolder = store.GetRootFolder(); var rootFolder = store.GetRootFolder();
FindContactFoldersRecursive(rootFolder, folders); FindContactFoldersRecursive(rootFolder, folders);
Marshal.ReleaseComObject(rootFolder); Marshal.ReleaseComObject(rootFolder);
Marshal.ReleaseComObject(store);
} }
catch (Exception ex) catch (Exception ex)
{ {
System.Diagnostics.Debug.WriteLine($"Error scanning store '{store.DisplayName}': {ex.Message}"); System.Diagnostics.Debug.WriteLine($"Error scanning store {i}: {ex.Message}");
} }
} }
@ -85,121 +104,141 @@ namespace StarfaceOutlookSync.Services
{ {
try try
{ {
var defaultFolder = ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts); var defaultFolder = ns.GetDefaultFolder(OlFolderContacts);
folders.Add(defaultFolder.FolderPath); folders.Add((string)defaultFolder.FolderPath);
Marshal.ReleaseComObject(defaultFolder); Marshal.ReleaseComObject(defaultFolder);
} }
catch { } catch { }
} }
Marshal.ReleaseComObject(stores);
Marshal.ReleaseComObject(ns); Marshal.ReleaseComObject(ns);
} }
catch (Exception ex) catch (Exception ex)
{ {
System.Diagnostics.Debug.WriteLine($"Error getting folders: {ex.Message}"); System.Diagnostics.Debug.WriteLine($"Error getting folders: {ex.Message}");
throw;
} }
return folders; return folders;
} }
private void FindContactFoldersRecursive(Outlook.MAPIFolder folder, List<string> paths) private void FindContactFoldersRecursive(dynamic folder, List<string> paths)
{ {
try try
{ {
// Kontaktordner erkennen: DefaultItemType ODER Ordnername enthaelt "Kontakt"/"Contact" if ((int)folder.DefaultItemType == OlContactItem)
if (folder.DefaultItemType == Outlook.OlItemType.olContactItem)
{ {
if (!paths.Contains(folder.FolderPath)) string path = folder.FolderPath;
paths.Add(folder.FolderPath); if (!paths.Contains(path))
paths.Add(path);
} }
// Alle Unterordner durchsuchen var subFolders = folder.Folders;
foreach (Outlook.MAPIFolder sub in folder.Folders) for (int i = 1; i <= (int)subFolders.Count; i++)
{ {
try try
{ {
var sub = subFolders[i];
FindContactFoldersRecursive(sub, paths); FindContactFoldersRecursive(sub, paths);
}
catch { }
finally
{
Marshal.ReleaseComObject(sub); Marshal.ReleaseComObject(sub);
} }
catch { }
} }
Marshal.ReleaseComObject(subFolders);
} }
catch (Exception ex) catch (Exception ex)
{ {
System.Diagnostics.Debug.WriteLine($"Error scanning folder '{folder.Name}': {ex.Message}"); System.Diagnostics.Debug.WriteLine($"Error scanning folder: {ex.Message}");
} }
} }
private Outlook.MAPIFolder GetFolderByPath(string folderPath) private dynamic GetFolderByPath(string folderPath)
{ {
var app = GetOutlookApp(); var app = GetOutlookApp();
var ns = app.GetNamespace("MAPI"); var ns = app.GetNamespace("MAPI");
// Standard-Kontaktordner als Fallback
if (string.IsNullOrEmpty(folderPath)) if (string.IsNullOrEmpty(folderPath))
return ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts); return ns.GetDefaultFolder(OlFolderContacts);
try try
{ {
// Pfad durchlaufen
var parts = folderPath.Split(new[] { '\\' }, StringSplitOptions.RemoveEmptyEntries); var parts = folderPath.Split(new[] { '\\' }, StringSplitOptions.RemoveEmptyEntries);
Outlook.MAPIFolder current = null; dynamic current = null;
foreach (Outlook.Store store in ns.Stores) var stores = ns.Stores;
for (int i = 1; i <= (int)stores.Count; i++)
{ {
if (store.GetRootFolder().Name == parts[0] || var store = stores[i];
store.GetRootFolder().FolderPath.TrimStart('\\') == parts[0]) var root = store.GetRootFolder();
string rootName = root.Name;
if (rootName == parts[0])
{ {
current = store.GetRootFolder(); current = root;
break; break;
} }
Marshal.ReleaseComObject(root);
Marshal.ReleaseComObject(store);
} }
Marshal.ReleaseComObject(stores);
if (current == null) if (current == null)
return ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts); return ns.GetDefaultFolder(OlFolderContacts);
for (int i = 1; i < parts.Length; i++) for (int i = 1; i < parts.Length; i++)
{ {
bool found = false; bool found = false;
foreach (Outlook.MAPIFolder sub in current.Folders) var subFolders = current.Folders;
for (int j = 1; j <= (int)subFolders.Count; j++)
{ {
if (sub.Name == parts[i]) var sub = subFolders[j];
if ((string)sub.Name == parts[i])
{ {
current = sub; current = sub;
found = true; found = true;
break; break;
} }
Marshal.ReleaseComObject(sub);
} }
Marshal.ReleaseComObject(subFolders);
if (!found) if (!found)
return ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts); return ns.GetDefaultFolder(OlFolderContacts);
} }
return current; return current;
} }
catch catch
{ {
return ns.GetDefaultFolder(Outlook.OlDefaultFolders.olFolderContacts); return ns.GetDefaultFolder(OlFolderContacts);
} }
} }
public List<UnifiedContact> GetContacts(string folderPath) public List<UnifiedContact> GetContacts(string folderPath)
{ {
var contacts = new List<UnifiedContact>(); var contacts = new List<UnifiedContact>();
try try
{ {
var folder = GetFolderByPath(folderPath); var folder = GetFolderByPath(folderPath);
var items = folder.Items; var items = folder.Items;
foreach (var item in items) for (int i = 1; i <= (int)items.Count; i++)
{ {
if (item is Outlook.ContactItem ci) dynamic item = null;
try
{ {
contacts.Add(MapFromOutlook(ci)); item = items[i];
Marshal.ReleaseComObject(ci); // Nur ContactItems verarbeiten (Class = 40 = olContact)
if ((int)item.Class == 40)
{
contacts.Add(MapFromOutlook(item));
}
}
catch { }
finally
{
if (item != null) Marshal.ReleaseComObject(item);
} }
} }
@ -219,7 +258,8 @@ namespace StarfaceOutlookSync.Services
try try
{ {
var folder = GetFolderByPath(folderPath); var folder = GetFolderByPath(folderPath);
var ci = (Outlook.ContactItem)folder.Items.Add(Outlook.OlItemType.olContactItem); var items = folder.Items;
dynamic ci = items.Add(OlContactItem);
MapToOutlook(contact, ci); MapToOutlook(contact, ci);
ci.Save(); ci.Save();
@ -227,6 +267,7 @@ namespace StarfaceOutlookSync.Services
contact.OutlookEntryId = ci.EntryID; contact.OutlookEntryId = ci.EntryID;
Marshal.ReleaseComObject(ci); Marshal.ReleaseComObject(ci);
Marshal.ReleaseComObject(items);
Marshal.ReleaseComObject(folder); Marshal.ReleaseComObject(folder);
return contact; return contact;
@ -244,7 +285,7 @@ namespace StarfaceOutlookSync.Services
{ {
var app = GetOutlookApp(); var app = GetOutlookApp();
var ns = app.GetNamespace("MAPI"); var ns = app.GetNamespace("MAPI");
var ci = (Outlook.ContactItem)ns.GetItemFromID(entryId); dynamic ci = ns.GetItemFromID(entryId);
MapToOutlook(contact, ci); MapToOutlook(contact, ci);
ci.Save(); ci.Save();
@ -267,7 +308,7 @@ namespace StarfaceOutlookSync.Services
{ {
var app = GetOutlookApp(); var app = GetOutlookApp();
var ns = app.GetNamespace("MAPI"); var ns = app.GetNamespace("MAPI");
var ci = (Outlook.ContactItem)ns.GetItemFromID(entryId); dynamic ci = ns.GetItemFromID(entryId);
ci.Delete(); ci.Delete();
Marshal.ReleaseComObject(ci); Marshal.ReleaseComObject(ci);
@ -282,36 +323,46 @@ namespace StarfaceOutlookSync.Services
} }
} }
private UnifiedContact MapFromOutlook(Outlook.ContactItem ci) private UnifiedContact MapFromOutlook(dynamic ci)
{ {
return new UnifiedContact return new UnifiedContact
{ {
OutlookEntryId = ci.EntryID ?? "", OutlookEntryId = (string)(ci.EntryID ?? ""),
FirstName = ci.FirstName ?? "", FirstName = (string)(ci.FirstName ?? ""),
LastName = ci.LastName ?? "", LastName = (string)(ci.LastName ?? ""),
Company = ci.CompanyName ?? "", Company = (string)(ci.CompanyName ?? ""),
JobTitle = ci.JobTitle ?? "", JobTitle = (string)(ci.JobTitle ?? ""),
Email = ci.Email1Address ?? "", Email = (string)(ci.Email1Address ?? ""),
EmailSecondary = ci.Email2Address ?? "", EmailSecondary = (string)(ci.Email2Address ?? ""),
PhoneWork = ci.BusinessTelephoneNumber ?? "", PhoneWork = (string)(ci.BusinessTelephoneNumber ?? ""),
PhoneMobile = ci.MobileTelephoneNumber ?? "", PhoneMobile = (string)(ci.MobileTelephoneNumber ?? ""),
PhoneHome = ci.HomeTelephoneNumber ?? "", PhoneHome = (string)(ci.HomeTelephoneNumber ?? ""),
Fax = ci.BusinessFaxNumber ?? "", Fax = (string)(ci.BusinessFaxNumber ?? ""),
Street = ci.BusinessAddressStreet ?? "", Street = (string)(ci.BusinessAddressStreet ?? ""),
City = ci.BusinessAddressCity ?? "", City = (string)(ci.BusinessAddressCity ?? ""),
PostalCode = ci.BusinessAddressPostalCode ?? "", PostalCode = (string)(ci.BusinessAddressPostalCode ?? ""),
State = ci.BusinessAddressState ?? "", State = (string)(ci.BusinessAddressState ?? ""),
Country = ci.BusinessAddressCountry ?? "", Country = (string)(ci.BusinessAddressCountry ?? ""),
Website = ci.WebPage ?? "", Website = (string)(ci.WebPage ?? ""),
Notes = ci.Body ?? "", Notes = (string)(ci.Body ?? ""),
Salutation = ci.Title ?? "", Salutation = (string)(ci.Title ?? ""),
Title = ci.Suffix ?? "", Birthday = GetBirthdayString(ci)
Birthday = ci.Birthday != DateTime.MinValue && ci.Birthday.Year > 1900
? ci.Birthday.ToString("yyyy-MM-dd") : ""
}; };
} }
private void MapToOutlook(UnifiedContact contact, Outlook.ContactItem ci) private string GetBirthdayString(dynamic ci)
{
try
{
DateTime bday = ci.Birthday;
if (bday.Year > 1900 && bday != DateTime.MinValue)
return bday.ToString("yyyy-MM-dd");
}
catch { }
return "";
}
private void MapToOutlook(UnifiedContact contact, dynamic ci)
{ {
ci.FirstName = contact.FirstName; ci.FirstName = contact.FirstName;
ci.LastName = contact.LastName; ci.LastName = contact.LastName;
@ -348,7 +399,7 @@ namespace StarfaceOutlookSync.Services
{ {
try { _outlookApp.Quit(); } catch { } try { _outlookApp.Quit(); } catch { }
} }
Marshal.ReleaseComObject(_outlookApp); try { Marshal.ReleaseComObject(_outlookApp); } catch { }
_outlookApp = null; _outlookApp = null;
} }
} }

1
src/StarfaceOutlookSync/StarfaceOutlookSync.csproj
View File

@ -19,7 +19,6 @@
<ItemGroup> <ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" /> <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Microsoft.Office.Interop.Outlook" Version="15.0.4797.1004" />
</ItemGroup> </ItemGroup>
</Project> </Project>