a982795388
KRITISCH: - emails/:id/thread bekommt canAccessCachedEmail - customers/:customerId/representatives/search bekommt canAccessCustomer (Buchstaben-Brute-Force konnte sonst die Kunden-DB enumerieren) HOCH: - birthdays/upcoming: Portal-User → 403 (Name/E-Mail/Telefon/Geb-Datum aller Kunden leakte) - contracts/:id/history (GET/POST/PUT/DELETE) bekommt canAccessContract - mailbox-accounts / unread-count / contracts/:id/emails/folder-counts bekommen canAccessCustomer bzw. canAccessContract - Vertreter-Vollmacht-Check ist jetzt live: neuer Helper getPortalAllowedCustomerIds() in accessControl.ts ruft hasAuthorization() für jedes vertretene Customer ab. Eingesetzt in getTasks/createSupportTicket/createCustomerReply/getAllTasks/ getTaskStats und updateCustomerConsent. Widerrufene Vollmachten haben jetzt SOFORT keinen Zugriff mehr (vorher: bis JWT abläuft). MITTEL: - confirmPasswordReset speichert portalPasswordEncrypted nicht mehr beim Self-Service-Reset (war nur für Admin-OTPs gedacht); + portalPasswordMustChange=false explizit - getCustomers pagination total reflektiert jetzt nur erlaubte IDs (über DB-Filter in customerService.getAllCustomers) Audit-Sweep (defense in depth, falls Rolle versehentlich Update- Permissions bekommt): - 16 cachedEmail-Operationen (markAsRead, toggleStar, assign/unassign, save-as-pdf/invoice/contract-document, save-to, attachment-targets, trash-ops) - 4 contract-Operationen (createFollowUp, createRenewal, snoozeContract, removeContractMeter) - 12 sub-CRUD-Operationen (address/bankcard/document/meter update+delete, meter-reading add/update/delete/transfer) - 2 representative-Operationen (add/remove) Live-verifiziert: Portal-Customer-3 auf alle fremden IDs → 403, Admin sieht alles, eigene Ressourcen weiterhin 200, Customer 1 mit widerrufener Vollmacht für Customer 3 → 0 fremde Verträge in der Response. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
106 lines
3.7 KiB
TypeScript
106 lines
3.7 KiB
TypeScript
import { Request, Response } from 'express';
|
|
import * as contractHistoryService from '../services/contractHistory.service.js';
|
|
import { logChange } from '../services/audit.service.js';
|
|
import { ApiResponse, AuthRequest } from '../types/index.js';
|
|
import { canAccessContract } from '../utils/accessControl.js';
|
|
|
|
export async function getHistoryEntries(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const contractId = parseInt(req.params.contractId);
|
|
if (!(await canAccessContract(req, res, contractId))) return;
|
|
const entries = await contractHistoryService.getHistoryEntries(contractId);
|
|
res.json({ success: true, data: entries } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(500).json({
|
|
success: false,
|
|
error: 'Fehler beim Laden der Historie',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function createHistoryEntry(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const contractId = parseInt(req.params.contractId);
|
|
if (!(await canAccessContract(req, res, contractId))) return;
|
|
const { title, description } = req.body;
|
|
|
|
if (!title || typeof title !== 'string' || title.trim().length === 0) {
|
|
res.status(400).json({
|
|
success: false,
|
|
error: 'Titel ist erforderlich',
|
|
} as ApiResponse);
|
|
return;
|
|
}
|
|
|
|
const entry = await contractHistoryService.createHistoryEntry(contractId, {
|
|
title: title.trim(),
|
|
description: description?.trim() || undefined,
|
|
isAutomatic: false,
|
|
createdBy: req.user?.email || 'unbekannt',
|
|
});
|
|
|
|
await logChange({
|
|
req, action: 'CREATE', resourceType: 'ContractHistory',
|
|
resourceId: entry.id.toString(),
|
|
label: `Historieneintrag "${title.trim()}" erstellt für Vertrag #${contractId}`,
|
|
});
|
|
|
|
res.status(201).json({ success: true, data: entry } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(400).json({
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Fehler beim Erstellen des Eintrags',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function updateHistoryEntry(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const contractId = parseInt(req.params.contractId);
|
|
if (!(await canAccessContract(req, res, contractId))) return;
|
|
const entryId = parseInt(req.params.entryId);
|
|
const { title, description } = req.body;
|
|
|
|
const entry = await contractHistoryService.updateHistoryEntry(contractId, entryId, {
|
|
title: title?.trim(),
|
|
description: description?.trim(),
|
|
});
|
|
|
|
await logChange({
|
|
req, action: 'UPDATE', resourceType: 'ContractHistory',
|
|
resourceId: entryId.toString(),
|
|
label: `Historieneintrag aktualisiert für Vertrag #${contractId}`,
|
|
});
|
|
|
|
res.json({ success: true, data: entry } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(400).json({
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Fehler beim Aktualisieren des Eintrags',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function deleteHistoryEntry(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const contractId = parseInt(req.params.contractId);
|
|
if (!(await canAccessContract(req, res, contractId))) return;
|
|
const entryId = parseInt(req.params.entryId);
|
|
|
|
await contractHistoryService.deleteHistoryEntry(contractId, entryId);
|
|
|
|
await logChange({
|
|
req, action: 'DELETE', resourceType: 'ContractHistory',
|
|
resourceId: entryId.toString(),
|
|
label: `Historieneintrag gelöscht für Vertrag #${contractId}`,
|
|
});
|
|
|
|
res.json({ success: true, message: 'Eintrag gelöscht' } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(400).json({
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Fehler beim Löschen des Eintrags',
|
|
} as ApiResponse);
|
|
}
|
|
}
|