08310ac302
Pentest hat einen echten Credential-Exfiltration-Angriff erfolgreich
durchgespielt: als Portal-User von Kunde A komplette Klartext-IMAP/SMTP-
Zugangsdaten der Mailbox von Kunde B abgreifbar.
Root Cause: GET /api/stressfrei-emails/:id hatte canAccessStressfreiEmail-
Check, ALLE 8 Sub-Endpoints unter :id/* hatten nur `authenticate +
requirePermission('customers:read')` — was jeder Portal-User de facto hat.
Betroffene Controller (alle gefixt mit canAccessStressfreiEmail als erster
Zeile):
stressfreiEmail.controller.ts:
- updateEmail (PUT /:id)
- deleteEmail (DELETE /:id)
- resetPassword (POST /:id/reset-password)
cachedEmail.controller.ts:
- getMailboxCredentials (GET /:id/credentials) ← KRITISCHSTER, lieferte
Klartext-IMAP/SMTP-Passwort + Server-Daten der fremden Mailbox
- getFolderCounts (GET /:id/folder-counts)
- syncAccount (POST /:id/sync)
- sendEmailFromAccount (POST /:id/send) — fremde Mailbox zum Versand
missbrauchbar
- enableMailbox (POST /:id/enable-mailbox)
- syncMailboxStatus (POST /:id/sync-mailbox-status)
Security-Monitor: canAccessResourceByCustomerId emittiert bei jedem
Fehlversuch ein ACCESS_DENIED MEDIUM-Event. Threshold-Detection erzeugt
bei >5 Versuchen in 5 min ein CRITICAL SUSPICIOUS-Event + Sofort-Alert.
Live-verifiziert (Portal-User Kunde A versucht Email-ID von Kunde B):
- alle 8 Sub-Routes → HTTP 403
- eigene Email-ID → 200/400 (Ownership-Check OK)
- 8× ACCESS_DENIED MEDIUM im Security-Monitor
Doku in docs/SECURITY-HARDENING.md als Runde 13.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
172 lines
5.9 KiB
TypeScript
172 lines
5.9 KiB
TypeScript
import { Request, Response } from 'express';
|
|
import * as stressfreiEmailService from '../services/stressfreiEmail.service.js';
|
|
import { logChange } from '../services/audit.service.js';
|
|
import { ApiResponse, AuthRequest } from '../types/index.js';
|
|
import { canAccessStressfreiEmail } from '../utils/accessControl.js';
|
|
|
|
export async function getEmailsByCustomer(req: Request, res: Response): Promise<void> {
|
|
try {
|
|
const customerId = parseInt(req.params.customerId);
|
|
const includeInactive = req.query.includeInactive === 'true';
|
|
const emails = await stressfreiEmailService.getEmailsByCustomerId(customerId, includeInactive);
|
|
res.json({ success: true, data: emails } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(500).json({
|
|
success: false,
|
|
error: 'Fehler beim Laden der Stressfrei-Wechseln Adressen',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function getEmail(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const emailId = parseInt(req.params.id);
|
|
if (!(await canAccessStressfreiEmail(req, res, emailId))) return;
|
|
|
|
const email = await stressfreiEmailService.getEmailById(emailId);
|
|
if (!email) {
|
|
res.status(404).json({
|
|
success: false,
|
|
error: 'Stressfrei-Wechseln Adresse nicht gefunden',
|
|
} as ApiResponse);
|
|
return;
|
|
}
|
|
|
|
// Sensibles Feld emailPasswordEncrypted nie an Portal-Kunden geben
|
|
const sanitized: any = { ...email };
|
|
if (req.user?.isCustomerPortal) {
|
|
delete sanitized.emailPasswordEncrypted;
|
|
}
|
|
res.json({ success: true, data: sanitized } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(500).json({
|
|
success: false,
|
|
error: 'Fehler beim Laden der Stressfrei-Wechseln Adresse',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function createEmail(req: Request, res: Response): Promise<void> {
|
|
try {
|
|
const customerId = parseInt(req.params.customerId);
|
|
const email = await stressfreiEmailService.createEmail({
|
|
...req.body,
|
|
customerId,
|
|
});
|
|
await logChange({
|
|
req, action: 'CREATE', resourceType: 'StressfreiEmail',
|
|
resourceId: email.id.toString(),
|
|
label: `Stressfrei-Wechseln Adresse angelegt für Kunde #${customerId}`,
|
|
customerId,
|
|
});
|
|
res.status(201).json({ success: true, data: email } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(400).json({
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Fehler beim Erstellen der Stressfrei-Wechseln Adresse',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function updateEmail(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const emailId = parseInt(req.params.id);
|
|
if (!(await canAccessStressfreiEmail(req, res, emailId))) return;
|
|
const email = await stressfreiEmailService.updateEmail(emailId, req.body);
|
|
await logChange({
|
|
req, action: 'UPDATE', resourceType: 'StressfreiEmail',
|
|
resourceId: email.id.toString(),
|
|
label: `Stressfrei-Wechseln Adresse aktualisiert`,
|
|
});
|
|
res.json({ success: true, data: email } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(400).json({
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Fehler beim Aktualisieren der Stressfrei-Wechseln Adresse',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function deleteEmail(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const emailId = parseInt(req.params.id);
|
|
if (!(await canAccessStressfreiEmail(req, res, emailId))) return;
|
|
await stressfreiEmailService.deleteEmail(emailId);
|
|
await logChange({
|
|
req, action: 'DELETE', resourceType: 'StressfreiEmail',
|
|
resourceId: emailId.toString(),
|
|
label: `Stressfrei-Wechseln Adresse gelöscht`,
|
|
});
|
|
res.json({ success: true, message: 'Stressfrei-Wechseln Adresse gelöscht' } as ApiResponse);
|
|
} catch (error) {
|
|
res.status(400).json({
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Fehler beim Löschen der Stressfrei-Wechseln Adresse',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function syncForwarding(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const emailId = parseInt(req.params.id);
|
|
if (!(await canAccessStressfreiEmail(req, res, emailId))) return;
|
|
|
|
const result = await stressfreiEmailService.syncForwardingForEmail(emailId);
|
|
if (!result.success) {
|
|
res.status(400).json({ success: false, error: result.error } as ApiResponse);
|
|
return;
|
|
}
|
|
|
|
const labelParts = [`Weiterleitungen: ${(result.forwardTargets || []).join(', ')}`];
|
|
if (result.passwordReset) labelParts.push('Mailbox-Passwort am Provider neu gesetzt');
|
|
|
|
await logChange({
|
|
req,
|
|
action: 'UPDATE',
|
|
resourceType: 'StressfreiEmail',
|
|
resourceId: emailId.toString(),
|
|
label: `Stressfrei-Sync: ${labelParts.join(' | ')}`,
|
|
});
|
|
|
|
res.json({
|
|
success: true,
|
|
data: {
|
|
forwardTargets: result.forwardTargets,
|
|
customerEmail: result.customerEmail,
|
|
passwordReset: result.passwordReset,
|
|
},
|
|
message: 'Weiterleitungen aktualisiert',
|
|
} as ApiResponse);
|
|
} catch (error) {
|
|
res.status(500).json({
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Fehler beim Synchronisieren der Weiterleitungen',
|
|
} as ApiResponse);
|
|
}
|
|
}
|
|
|
|
export async function resetPassword(req: AuthRequest, res: Response): Promise<void> {
|
|
try {
|
|
const emailId = parseInt(req.params.id);
|
|
if (!(await canAccessStressfreiEmail(req, res, emailId))) return;
|
|
const result = await stressfreiEmailService.resetMailboxPassword(emailId);
|
|
if (!result.success) {
|
|
res.status(400).json({
|
|
success: false,
|
|
error: result.error,
|
|
} as ApiResponse);
|
|
return;
|
|
}
|
|
res.json({
|
|
success: true,
|
|
data: { password: result.password },
|
|
message: 'Passwort wurde zurückgesetzt',
|
|
} as ApiResponse);
|
|
} catch (error) {
|
|
res.status(500).json({
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Fehler beim Zurücksetzen des Passworts',
|
|
} as ApiResponse);
|
|
}
|
|
}
|